Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add French translation #2861

Merged
2 commits merged into from
Apr 23, 2020
Merged

add French translation #2861

2 commits merged into from
Apr 23, 2020

Conversation

nerekihs
Copy link
Contributor

@nerekihs nerekihs commented Apr 22, 2020 •
edited
Loading

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

  • Require translation update

  • Require document update (readme.md, wikipage, etc)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

Add French translation (first version) to i18n.csv

@chenshaoju
Copy link
Collaborator

Thanks for the send pull request,Please wait the developer to review the code.

@celeron533 celeron533 requested review from celeron533, chenshaoju and a user April 22, 2020 10:38
chenshaoju
chenshaoju reviewed Apr 22, 2020
View reviewed changes
Copy link
Collaborator

@chenshaoju chenshaoju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Base DeepL Translator tools, It's looks good to me, but someone else must approve. 👍

@chenshaoju chenshaoju self-requested a review April 22, 2020 12:40
@celeron533
Copy link
Contributor

Thanks @nerekihs

@ghost ghost merged commit 873d8f1 into shadowsocks:master Apr 23, 2020
@ghost ghost mentioned this pull request Apr 23, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenshaoju chenshaoju chenshaoju approved these changes

@celeron533 celeron533 Awaiting requested review from celeron533

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nerekihs @chenshaoju @celeron533