NLogConfig - TouchAndApplyNLogConfig with Exception handler #2846
Conversation
ghost
requested a review
from 
|
Thanks @snakefoot , is has been fixed in 5bc4a0b |
| return; | ||
| } | ||
|
|
||
| LoadConfiguration(); // Load the new config-file |
There was a problem hiding this comment.
There may not have the NLog config file due to the previous write permission issue.
There was a problem hiding this comment.
It only performs the LoadConfiguration if it was successful in creating a new one. So if it can write to the location, then it should also be able to read.
There was a problem hiding this comment.
So the routine is like this? I think this change is ok then.
When write error: Line 113->116 throw error ->118 catch error->120->121 return
When config exist: (config auto loaded by NLog itself at program start) 113->114 return
When config not exist: 113->116->124 load config->return
There was a problem hiding this comment.
Yes it returns without doing anything for all cases. Except for the very first time where it successfully have created a new default NLog.config.
There was a problem hiding this comment.
Since the 5bc4a0b is committed to fix the CurrentDirectory issue. The NLog config file is always create/read/write on the same place in file system. Will merge the code soon.
PS:
Before the previous autostart issue fix, SS may create the NLog config file in the wrong place, such as System folder and request the NLog to load it.
Then the following code change the CurrentDirectory to Application.StartPath
Which made the NLog file location inconsistent. When user change the log level and NLog need to reload the config file, may fail.
Please follow the guide below
What is the purpose of your pull request?
Description
Avoid application crash when not having file permissions to setup default NLog.config. See also #2841