Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: get password from env variable #249

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: get password from env variable #249

merged 2 commits into from
Sep 13, 2023

Conversation

KDima23
Copy link

@KDima23 KDima23 commented Aug 2, 2023

Adds possibility to get password from environment variable

@riobard
Copy link

riobard commented Sep 12, 2023

@KDima23 Thanks for the PR. The environment variable should better be prefixed e.g. SS_PASSWORD to avoid collision with others.

KDima23
KDima23 commented Sep 12, 2023
View reviewed changes
Copy link
Author

@KDima23 KDima23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely right. Added these changes.
@riobard

@riobard riobard merged commit 43c8294 into shadowsocks:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KDima23 @riobard