Fix the overlap problem of udp decryption.

Now return the correct length of data read by ReadFrom.
shadowsocks · Aug 29, 2018 · 89e875b · 89e875b
1 parent 18fc4a9
commit 89e875b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/shadowaead/packet.go b/shadowaead/packet.go
@@ -88,6 +88,10 @@ func (c *packetConn) ReadFrom(b []byte) (int, net.Addr, error) {
 	if err != nil {
 		return n, addr, err
 	}
-	b, err = Unpack(b, b[:n], c)
-	return len(b), addr, err
+	bb, err := Unpack(b[c.Cipher.SaltSize():], b[:n], c)
+	if err != nil {
+		return n, addr, err
+	}
+	copy(b, bb)
+	return len(bb), addr, err
 }
diff --git a/shadowstream/packet.go b/shadowstream/packet.go
@@ -76,5 +76,5 @@ func (c *packetConn) ReadFrom(b []byte) (int, net.Addr, error) {
 		return n, addr, err
 	}
 	copy(b, bb)
-	return len(b), addr, err
+	return len(bb), addr, err
 }