Skip to content

Fix the missing newline characters for the breaking changes#9293

Merged
jkwak-work merged 1 commit intoshader-slang:masterfrom
jkwak-work:fix/release-note-newline
Dec 10, 2025
Merged

Fix the missing newline characters for the breaking changes#9293
jkwak-work merged 1 commit intoshader-slang:masterfrom
jkwak-work:fix/release-note-newline

Conversation

@jkwak-work
Copy link
Copy Markdown
Collaborator

When generating the release note, the script was missing the new line characters for the breaking changes.

The following is an example of the problem:

=== Breaking changes ===
72761cc Add error diagnostic for integer literals that don't fit into uint64_t (#9208 Remove the deprecated hlsl_coopvec_poc capability that was for POC CoopVec (#9213 Add type-flow analysis pass for specialized dynamic dispatch (#7968)

With this PR, it will be fixed as below:

=== Breaking changes ===
72761cc Add error diagnostic for integer literals that don't fit into uint64_t (#9208)
cc73e8d Remove the deprecated hlsl_coopvec_poc capability that was for POC CoopVec (#9213)
4280f24 Add type-flow analysis pass for specialized dynamic dispatch (#7968)

@jkwak-work jkwak-work self-assigned this Dec 9, 2025
@jkwak-work jkwak-work requested a review from a team as a code owner December 9, 2025 17:14
@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Dec 9, 2025
Copy link
Copy Markdown
Contributor

@aidanfnv aidanfnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkwak-work jkwak-work added this pull request to the merge queue Dec 10, 2025
Merged via the queue into shader-slang:master with commit dea92ad Dec 10, 2025
20 checks passed
gtong-nv pushed a commit that referenced this pull request Dec 15, 2025
When generating the release note, the script was missing the new line
characters for the breaking changes.

The following is an example of the problem:
> === Breaking changes ===

72761cc
Add error diagnostic for integer literals that don't fit into uint64_t
(#9208
Remove the deprecated hlsl_coopvec_poc capability that was for POC
CoopVec
(#9213
Add type-flow analysis pass for specialized dynamic dispatch
(#7968)

With this PR, it will be fixed as below:
>=== Breaking changes ===

72761cc
Add error diagnostic for integer literals that don't fit into uint64_t
(#9208)

cc73e8d
Remove the deprecated hlsl_coopvec_poc capability that was for POC
CoopVec (#9213)

4280f24
Add type-flow analysis pass for specialized dynamic dispatch
(#7968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: non-breaking PRs without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants