Update LLVM from 13.0.1 to 14.0.6

[samestep]

Full set of mutually exclusive choices for upgrading LLVM:

• Update LLVM from 13.0.1 to 14.0.6 #8031 (you are here)
• Update LLVM from 13.0.1 to 15.0.7 #8035
• Update LLVM from 13.0.1 to 16.0.6 #8036
• Update LLVM from 13.0.1 to 17.0.6 #8034
• Update LLVM from 13.0.1 to 18.1.8 #8038
• Update LLVM from 13.0.1 to 19.1.7 #8039
• Update LLVM from 13.0.1 to 20.1.8 #8033

Alternative to #8028. Required some minor changes due to these upstream commits:

• llvm/llvm-project@e463b69
• llvm/llvm-project@89b5706

[jkwak-work]

Looks good to me.
Thanks for the fix.

I don't think our CI covers this part of changes.
I am not sure how to make sure it works?

[samestep]

@jkwak-work hmm, not sure what you mean; doesn't this get automatically built in CI?

slang/.github/actions/common-setup/action.yml

Lines 82 to 109 in 34840bb

	# Try to restore an LLVM install, and build it otherwise
	- uses: actions/cache/restore@v4
	id: cache-llvm
	if: inputs.build-llvm == 'true'
	with:
	path: ${{ github.workspace }}/build/llvm-project-install
	# Use os*compiler*platform in lieu of an ABI key here, which is what we really want
	key: llvm-${{ inputs.os }}-${{ inputs.compiler }}-${{ inputs.platform }}-${{ hashFiles('external/build-llvm.sh') }}
	- name: Build LLVM
	if: inputs.build-llvm == 'true' && steps.cache-llvm.outputs.cache-hit != 'true'
	shell: bash
	run: |
	./external/build-llvm.sh \
	--install-prefix "${{github.workspace}}/build/llvm-project-install" \
	--repo "https://${{github.token}}@github.com/llvm/llvm-project"
	- uses: actions/cache/save@v4
	if: inputs.build-llvm == 'true' && steps.cache-llvm.outputs.cache-hit != 'true'
	with:
	path: ${{ github.workspace }}/build/llvm-project-install
	key: ${{ steps.cache-llvm.outputs.cache-primary-key }}
	- name: Set environment variable for CMake
	shell: bash
	run: |
	if [ "${{inputs.build-llvm}}" == "true" ]; then
	echo "LLVM_DIR=${{ github.workspace }}/build/llvm-project-install" >> "$GITHUB_ENV"
	echo "Clang_DIR=${{ github.workspace }}/build/llvm-project-install" >> "$GITHUB_ENV"
	fi

That gets used by most of our GitHub Actions workflows:

$ git grep --files-with-matches '.github/actions/common-setup'
.github/workflows/benchmark.yml
.github/workflows/check-cmdline-ref.yml
.github/workflows/ci.yml
.github/workflows/compile-regression-test.yml
.github/workflows/falcor-compiler-perf-test.yml
.github/workflows/falcor-test.yml
.github/workflows/push-benchmark-results.yml
.github/workflows/regenerate-cmdline-ref.yml
.github/workflows/release.yml
.github/workflows/vk-gl-cts-nightly.yml

Also: what LLVM version do we want to upgrade to? We could upgrade to 14 with this PR, but we could alternatively upgrade to 15 or 16 which already work on Linux and macOS (see my other PRs), just requiring what I'm guessing will be a small fix for Windows; or we could just try to go all the way to 20 since that's the newest version. Is there a particular reason for choosing an older version instead of a newer one?

[jkwak-work]

@jkwak-work hmm, not sure what you mean; doesn't this get automatically built in CI?

slang/.github/actions/common-setup/action.yml

Lines 82 to 109 in 34840bb

	# Try to restore an LLVM install, and build it otherwise
	- uses: actions/cache/restore@v4
	id: cache-llvm
	if: inputs.build-llvm == 'true'
	with:
	path: ${{ github.workspace }}/build/llvm-project-install
	# Use os*compiler*platform in lieu of an ABI key here, which is what we really want
	key: llvm-${{ inputs.os }}-${{ inputs.compiler }}-${{ inputs.platform }}-${{ hashFiles('external/build-llvm.sh') }}
	- name: Build LLVM
	if: inputs.build-llvm == 'true' && steps.cache-llvm.outputs.cache-hit != 'true'
	shell: bash
	run: |
	./external/build-llvm.sh \
	--install-prefix "${{github.workspace}}/build/llvm-project-install" \
	--repo "https://${{github.token}}@github.com/llvm/llvm-project"
	- uses: actions/cache/save@v4
	if: inputs.build-llvm == 'true' && steps.cache-llvm.outputs.cache-hit != 'true'
	with:
	path: ${{ github.workspace }}/build/llvm-project-install
	key: ${{ steps.cache-llvm.outputs.cache-primary-key }}
	- name: Set environment variable for CMake
	shell: bash
	run: |
	if [ "${{inputs.build-llvm}}" == "true" ]; then
	echo "LLVM_DIR=${{ github.workspace }}/build/llvm-project-install" >> "$GITHUB_ENV"
	echo "Clang_DIR=${{ github.workspace }}/build/llvm-project-install" >> "$GITHUB_ENV"
	fi

That gets used by most of our GitHub Actions workflows:

$ git grep --files-with-matches '.github/actions/common-setup'
.github/workflows/benchmark.yml
.github/workflows/check-cmdline-ref.yml
.github/workflows/ci.yml
.github/workflows/compile-regression-test.yml
.github/workflows/falcor-compiler-perf-test.yml
.github/workflows/falcor-test.yml
.github/workflows/push-benchmark-results.yml
.github/workflows/regenerate-cmdline-ref.yml
.github/workflows/release.yml
.github/workflows/vk-gl-cts-nightly.yml

Also: what LLVM version do we want to upgrade to? We could upgrade to 14 with this PR, but we could alternatively upgrade to 15 or 16 which already work on Linux and macOS (see my other PRs), just requiring what I'm guessing will be a small fix for Windows; or we could just try to go all the way to 20 since that's the newest version. Is there a particular reason for choosing an older version instead of a newer one?

Oh. You are right. I forgot about that.
CI builds it on a certain configurations.
https://github.com/shader-slang/slang/blob/master/.github/workflows/ci.yml#L51-L52

[jkwak-work]

Looks good to me.