Add more system dependency options to CMake#7987
Add more system dependency options to CMake#7987samestep merged 4 commits intoshader-slang:masterfrom
Conversation
Allows opt-in for sourcing the following dependencies from the system, instead of using the vendored ones: - miniz - lz4 - vulkan-headers - spirv-tools - glslang
|
For context, this is a followup on the conversation from NixOS/nixpkgs#424153. |
|
/format |
|
🌈 Formatted, please merge the changes from this PR |
jkwak-work
left a comment
There was a problem hiding this comment.
Looks good to me.
@expipiplus1 , can you review since you are more faimilar with CMake setting?
|
@niklaskorz , After running |
Format code for PR shader-slang#7987
|
This change seems to conflict or duplicate to another PR that was merged recently @niklaskorz , can you review the PR and see if this PR is still needed? |
|
@jkwak-work I merged |
jkwak-work
left a comment
There was a problem hiding this comment.
I made a mistake on my previous comment.
The keywords "Vulkan" and "SPIRV" looked confusingly similar to me.
It looks good to me.
Allows opt-in for sourcing the following dependencies from the system,
instead of using the vendored ones:
(some of these already had options that weren't working, as either it expected them to be static libraries or it was expecting to be embedded in another CMakeList that should provide the package, instead of finding the package itself)
This is based on a patch we currently maintain inside nixpkgs, but as it
frequently conflicts with new slang releases, it would be nice to see get
this upstream.