Skip to content

Improve performance of AST deserialization #7935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tangent-vector merged 11 commits into from
Aug 7, 2025
Merged

Improve performance of AST deserialization #7935

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5237da1
Improve performance of AST deserialization
tangent-vector Jul 24, 2025
27b237f
fixup
tangent-vector Jul 28, 2025
9ccd48b
format code
slangbot Jul 28, 2025
2ea6339
Merge pull request #28 from slangbot/format-7935-improve-ast-deserial…
tangent-vector Jul 28, 2025
dbf61bf
Merge branch 'master' into improve-ast-deserialization-performance
tangent-vector Jul 28, 2025
1913153
typo
tangent-vector Jul 29, 2025
0ee7342
Merge branch 'master' into improve-ast-deserialization-performance
tangent-vector Jul 29, 2025
74887f2
Merge remote-tracking branch 'origin/master' into improve-ast-deseria…
tangent-vector Aug 6, 2025
4b2dbbf
Merge branch 'master' into improve-ast-deserialization-performance
tangent-vector Aug 6, 2025
b6f54ec
Merge branch 'master' into improve-ast-deserialization-performance
tangent-vector Aug 6, 2025
3277726
Merge branch 'master' into improve-ast-deserialization-performance
tangent-vector Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions source/core/slang-relative-ptr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@ struct RelativePtr
using Offset = typename Traits::Offset;
using UOffset = typename Traits::UOffset;

RelativePtr() = default;
RelativePtr(RelativePtr const& ptr) { set(ptr); }
RelativePtr(RelativePtr&& ptr) { set(ptr); }
RelativePtr(T* ptr) { set(ptr); }
SLANG_FORCE_INLINE RelativePtr() = default;
SLANG_FORCE_INLINE RelativePtr(RelativePtr const& ptr) { set(ptr); }
SLANG_FORCE_INLINE RelativePtr(RelativePtr&& ptr) { set(ptr); }
SLANG_FORCE_INLINE RelativePtr(T* ptr) { set(ptr); }

void operator=(RelativePtr const& ptr) { set(ptr); }
void operator=(RelativePtr&& ptr) { set(ptr); }
void operator=(T* ptr) { set(ptr); }
SLANG_FORCE_INLINE void operator=(RelativePtr const& ptr) { set(ptr); }
SLANG_FORCE_INLINE void operator=(RelativePtr&& ptr) { set(ptr); }
SLANG_FORCE_INLINE void operator=(T* ptr) { set(ptr); }

T* get() const
{
Expand Down Expand Up @@ -79,8 +79,8 @@ struct RelativePtr
SLANG_ASSERT(intptr_t(_offset) == offsetVal);
}

operator T*() const { return get(); }
T* operator->() const { return get(); }
SLANG_FORCE_INLINE operator T*() const { return get(); }
SLANG_FORCE_INLINE T* operator->() const { return get(); }

private:
Offset _offset = 0;
Expand Down
36 changes: 0 additions & 36 deletions source/slang/slang-fossil.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,30 +77,6 @@ Fossil::AnyValPtr getRootValue(void const* data, Size size)

} // namespace Fossil

Size FossilizedStringObj::getSize() const
{
auto sizePtr = (FossilUInt*)this - 1;
return Size(*sizePtr);
}

UnownedTerminatedStringSlice FossilizedStringObj::get() const
{
auto size = getSize();
return UnownedTerminatedStringSlice((char*)this, size);
}

Count FossilizedContainerObjBase::getElementCount() const
{
auto countPtr = (FossilUInt*)this - 1;
return Size(*countPtr);
}

FossilizedValLayout* FossilizedVariantObj::getContentLayout() const
{
auto layoutPtrPtr = (FossilizedPtr<FossilizedValLayout>*)this - 1;
return (*layoutPtrPtr).get();
}

Fossil::AnyValRef Fossil::ValRef<FossilizedContainerObjBase>::getElement(Index index) const
{
SLANG_ASSERT(index >= 0);
Expand Down Expand Up @@ -137,16 +113,4 @@ Fossil::AnyValRef Fossil::ValRef<FossilizedRecordVal>::getField(Index index) con
return Fossil::AnyValRef(fieldPtr, fieldInfo->layout);
}

#if 0
FossilizedValRef getVariantContent(FossilizedVariantObjRef variantRef)
{
return getVariantContent(variantRef.getData());
}
#endif

Fossil::AnyValPtr getVariantContentPtr(FossilizedVariantObj* variantPtr)
{
return Fossil::AnyValPtr(variantPtr->getContentDataPtr(), variantPtr->getContentLayout());
}

} // namespace Slang
Loading
Loading