Skip to content

Bring back hooks for auto formatting and ensure build works#7811

Merged
szihs merged 2 commits intoshader-slang:masterfrom
szihs:haaggarwal/claude_robust
Aug 5, 2025
Merged

Bring back hooks for auto formatting and ensure build works#7811
szihs merged 2 commits intoshader-slang:masterfrom
szihs:haaggarwal/claude_robust

Conversation

@szihs
Copy link
Copy Markdown
Collaborator

@szihs szihs commented Jul 17, 2025

No description provided.

@szihs szihs requested a review from a team as a code owner July 17, 2025 16:36
@szihs szihs force-pushed the haaggarwal/claude_robust branch from ea8b913 to ddb6669 Compare July 17, 2025 18:33
@szihs szihs added the pr: non-breaking PRs without breaking changes label Jul 17, 2025
@szihs szihs force-pushed the haaggarwal/claude_robust branch from c326de9 to 1711a36 Compare July 18, 2025 08:24
@szihs szihs requested a review from csyonghe July 18, 2025 12:21
jkwak-work
jkwak-work previously approved these changes Jul 18, 2025
@szihs
Copy link
Copy Markdown
Collaborator Author

szihs commented Jul 21, 2025

You can't do it in the action, because commit and push is done in the "Claude action" step, running anything after that won't affect the checked in code.

That's not problem. Anyway I will mark it as draft as need to work on this,

Hooks can run , but jay commented it would interfere with the claude sense of file content and force to re-read the file, wasting calls.

I have a working copy of local setup where I can run workflow. Most likely we should do on pretool hook with match to 'git add' cmd

Copy link
Copy Markdown
Collaborator

@csyonghe csyonghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of using hooks here, can we just setup git hooks to run format pre-commit?

@szihs szihs marked this pull request as draft July 30, 2025 07:53
@szihs szihs force-pushed the haaggarwal/claude_robust branch from 1711a36 to 8c4fc2c Compare August 5, 2025 07:34
@szihs szihs force-pushed the haaggarwal/claude_robust branch from 8c4fc2c to ece1790 Compare August 5, 2025 07:53
@szihs
Copy link
Copy Markdown
Collaborator Author

szihs commented Aug 5, 2025

/format

@szihs
Copy link
Copy Markdown
Collaborator Author

szihs commented Aug 5, 2025

instead of using hooks here, can we just setup git hooks to run format pre-commit?

that would be more intrusive change. Given the formatting scripts is not cross-platform.

@slangbot
Copy link
Copy Markdown
Contributor

slangbot commented Aug 5, 2025

🌈 Formatted, please merge the changes from this PR

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>
@szihs szihs requested review from csyonghe and jkwak-work August 5, 2025 08:11
@szihs szihs marked this pull request as ready for review August 5, 2025 08:11
Copy link
Copy Markdown
Collaborator

@jkwak-work jkwak-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@szihs szihs added this pull request to the merge queue Aug 5, 2025
Merged via the queue into shader-slang:master with commit 2d775b5 Aug 5, 2025
18 checks passed
@szihs szihs mentioned this pull request Aug 6, 2025
@szihs szihs deleted the haaggarwal/claude_robust branch February 6, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: non-breaking PRs without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants