Convert gfx unit tests and examples to use slang-rhi by gtong-nv · Pull Request #7577 · shader-slang/slang

gtong-nv · 2025-07-01T17:09:55Z

All examples and gfx-unit-tests are ported to use slang-rhi and PASS in CI
Some tests are already ported and running in slang-rhi CI; can be remove to save CI capacity
Some tests are disabled for now given no equivalent API in slang-rhi and no longer applicable
See summary below

Disabled/Problematic Tests

Tests that need attention or have unresolved issues:

Test File	Issue	Action Needed
`precompiled-module-2.cpp`	Test failed - segfault	porting WIP in `slang-rhi\tests\test-precompiled-module-cache.cpp`
`root-mutable-shader-object.cpp`	Test failed - buffer not being modified by shader	porting WIP in `slang-rhi\tests\test-mutable-shader-object.cpp`
`get-supported-resource-states-test.cpp`	No equivalent API; Replaced by `IDevice::getFormatSupport`	Covered by other test; Can remove
`resolve-resource-tests.cpp`	No `resolveResource` API	Covered by other test; Can remove

Duplicated Tests (Ready for Removal)

These tests have equivalent implementations in slang-rhi and can be safely deleted:

GFX Test File	Slang-RHI Equivalent	Status
`clear-texture-test.cpp`	`test-cmd-clear-texture.cpp`	✅ Can remove
`copy-texture-tests.cpp`	`test-cmd-copy-texture.cpp`	✅ Can remove
`format-unit-tests.cpp`	`test-formats.cpp`	✅ Can remove
`instanced-draw-tests.cpp`	`test-cmd-draw.cpp`	✅ Can remove
`shader-cache-tests.cpp`	`test-shader-cache.cpp`	✅ Can remove
`shared-textures-tests.cpp`	`test-texture-shared.cpp`	✅ Can remove
`swap-chain-resize-test.cpp`	`test-surface.cpp`	✅ Can remove
`texture-types-tests.cpp`	`test-texture-types.cpp`	✅ Can remove
`sampler-array.cpp`	`test-sampler-array.cpp`	✅ Fixed & can remove
`uint16-structured-buffer.cpp`	`test-uint16-buffer.cpp`	✅ Fixed & can remove
`root-shader-parameter.cpp`	`test-root-shader-parameter.cpp`	✅ Fixed & can remove

Closes: #7564

CLAassistant · 2025-07-03T16:54:22Z

All committers have signed the CLA.

gtong-nv · 2025-07-05T18:59:43Z

/format

slangbot · 2025-07-05T19:00:24Z

🌈 Formatted, please merge the changes from this PR

csyonghe · 2025-07-08T01:49:34Z

There is also an tests/cpu-program/gfx-smoke.slang test that uses gfx, we need to move it to rhi too. But this will require us do a slang-rhi.slang to expose the rhi interface to slang.

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>

gtong-nv · 2025-07-08T06:22:19Z

There is also an tests/cpu-program/gfx-smoke.slang test that uses gfx, we need to move it to rhi too. But this will require us do a slang-rhi.slang to expose the rhi interface to slang.

I removed tests/cpu-program/gfx-smoke.slang for now thinking it was used to test the slang-gfx layer. Do you mean we should move tools\gfx\gfx.slang to an slang-rhi.slang module in slang-rhi?

gtong-nv · 2025-07-08T15:56:27Z

/format

slangbot · 2025-07-08T15:57:10Z

🌈 Formatted, please merge the changes from this PR

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>

jkwak-work

Great job!
Looks good to me.

examples/example-base/example-base.h

examples/example-base/example-base.cpp

tools/gfx-unit-test/copy-texture-tests.cpp

tools/gfx-unit-test/existing-device-handle-test.cpp

jkwak-work · 2025-07-08T18:57:21Z

tools/gfx-unit-test/get-supported-resource-states-test.cpp

+ * This test has been disabled because the slang-rhi API
+ * does not provide equivalent functionality for querying format-supported
+ * resource states. The old gfx API's getFormatSupportedResourceStates() is
+ * replaced by with IDevice::getFormatSupport.


@skallweitNV , do we have a plan to support the feature on RHI?
If not, we should remove this file entirely.

tools/gfx-unit-test/link-time-constant-array-size.cpp

jkwak-work · 2025-07-08T19:06:39Z

tools/platform/gui.cpp

+    // For now, skip pipeline creation since we don't have a shader program
+    // This would need to be completed for full functionality
+#if 0


Do we need an issue to follow up this?

I will create an issue

kaizhangNV · 2025-07-09T02:30:55Z

There is also an tests/cpu-program/gfx-smoke.slang test that uses gfx, we need to move it to rhi too. But this will require us do a slang-rhi.slang to expose the rhi interface to slang.

I removed tests/cpu-program/gfx-smoke.slang for now thinking it was used to test the slang-gfx layer. Do you mean we should move tools\gfx\gfx.slang to an slang-rhi.slang module in slang-rhi?

gfx-smoke.slang is slang code that will targeting CPU, and that code is to use gfx to run a simple slang compute shader. It's to demonstrate the CPU target is working, and our implementation for gfx.slang and slang.slang is working correctly.

gfx.slang and slang.slang are located at tools/gfx/ directory, you can see they are slang modules imported at beginning of gfx-smoke.slang.

slang.slang and gfx.slang includes minimum required definitions that is good enough for gfx-smoke.slang to run.

slang.slang are just copying from slang.h
and gfx.slang are just copying from gfx.h, but since those are slang code, so some syntax has to be changed.

To convert gfx-smoke.slang to rhi-smoke.slang, you need to not only change this file, but also convert gfx.slang to rhi.slang to make thing consistent both.

But most changes are just trivial, because gfx and rhi shares lots of definitions.

jkwak-work

Looks good to me

But I am not sure what is going on with rhi.slang.

csyonghe

Looks good to me.

niklaskorz · 2025-07-30T08:10:10Z

tools/CMakeLists.txt

            imgui
            stb
            $<$<BOOL:${SLANG_ENABLE_XLIB}>:X11::X11>
+            $<$<BOOL:${SLANG_ENABLE_SLANG_RHI}>:slang-rhi>


This suggests that enabling slang-rhi to compile the platform module is optional.
However, when setting SLANG_ENABLE_SLANG_RHI=OFF, compilation fails as tools/platfom/gui.h tries to include <slang-rhi.h> regardless of this option.

We currently rely on SLANG_ENABLE_SLANG_RHI=OFF in nixpkgs as slang-rhi tries to download all of its dependencies through FetchPackage and there is no way to provide them offline it seems, thus we have to keep slang-rhi disabled in nixpkgs.

Thanks for pointing this out and sorry for missing this comment. gfx-unit-test relies on slang-rhi now. We should not build gfx-unit-test if for SLANG_ENABLE_SLANG_RHI=OFF. I will push a change to address this.

gtong-nv force-pushed the gfx-to-slang-rhi branch from aa5aff0 to 40e5f1c Compare July 3, 2025 17:20

slangbot mentioned this pull request Jul 5, 2025

Format code for PR #7577 #7621

Merged

gtong-nv marked this pull request as ready for review July 7, 2025 17:41

gtong-nv requested a review from a team as a code owner July 7, 2025 17:41

gtong-nv and others added 22 commits July 7, 2025 23:15

Port first gfx unit test to slang-rhi

1b196de

port triangle example to use slang-rhi

6c9b4b9

port platform-test to slang-rhi

754efe6

Update platform-test to throttle mouse move events

8a9f490

port gpu-printing example to use slang-rhi

293bf87

port model-viewer example to use slang-rhi

26ae455

port ray-tracing example to use slang-rhi

f4cad1b

port ray-tracing pipeline example to use slang-rhi

c5b19a4

port reflection parameter blocks example to use slang-rhi

d750b58

port shader-object example to use slang-rhi

af3b0a5

port shader-toy example to use slang-rhi

efb5618

Port most of tests to slang-rhi

b26ce80

port link-time-constant-array-size to use slang-rhi

6560735

Fix tests and find matching tests in slang-rhi

74016d2

port autodiff-texture

f84e23b

remove gfx target; port nv-aftermath-example

6d33a5e

update include path for shader-cursor.h

b14174c

Disabled 2 more ported tests

aef3787

fix build error

2731ca2

remove gfx test

2231d05

put slang-rhi (static-lib) before slang (shared)

e3739c2

format code (#7621)

6181009

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>

add debug callback

cfbc002

gtong-nv force-pushed the gfx-to-slang-rhi branch from d150eed to cfbc002 Compare July 8, 2025 06:15

gtong-nv added the pr: non-breaking PRs without breaking changes label Jul 8, 2025

slangbot mentioned this pull request Jul 8, 2025

Format code for PR #7577 #7649

Merged

format code (#7649)

336b273

Co-authored-by: slangbot <186143334+slangbot@users.noreply.github.com>

jkwak-work previously approved these changes Jul 8, 2025

View reviewed changes

gtong-nv dismissed jkwak-work’s stale review via e5ac107 July 8, 2025 20:35

Address review comments; revert back to use SLANG_CHECK_MSG

3ded299

gtong-nv force-pushed the gfx-to-slang-rhi branch from e5ac107 to 3ded299 Compare July 8, 2025 21:37

Merge branch 'master' into gfx-to-slang-rhi

2d949a6

gtong-nv enabled auto-merge July 8, 2025 21:39

jkwak-work reviewed Jul 9, 2025

View reviewed changes

csyonghe approved these changes Jul 9, 2025

View reviewed changes

gtong-nv added this pull request to the merge queue Jul 9, 2025

Merged via the queue into master with commit 43d0c21 Jul 9, 2025
25 of 26 checks passed

This was referenced Jul 14, 2025

shader-slang: 2025.8.1 -> 2025.12.1 NixOS/nixpkgs#424153

Merged

Support a reproducible build via Nix juliusikkala/slang-simple-vulkan#1

Merged

niklaskorz reviewed Jul 30, 2025

View reviewed changes

This was referenced Aug 1, 2025

Add lock file to .gitignore #8029

Merged

Add back GFX smoke test #8030

Merged

samestep mentioned this pull request Aug 20, 2025

Update slang-rhi deps for gfx-unit-test #8237

Merged

rootjalex mentioned this pull request Aug 21, 2025

examples/ray-tracing-pipeline segfaults #7525

Closed

Conversation

gtong-nv commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Disabled/Problematic Tests

Duplicated Tests (Ready for Removal)

Uh oh!

CLAassistant commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gtong-nv commented Jul 5, 2025

Uh oh!

slangbot commented Jul 5, 2025

Uh oh!

csyonghe commented Jul 8, 2025

Uh oh!

gtong-nv commented Jul 8, 2025

Uh oh!

gtong-nv commented Jul 8, 2025

Uh oh!

slangbot commented Jul 8, 2025

Uh oh!

jkwak-work left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkwak-work Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jkwak-work Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

gtong-nv Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

kaizhangNV commented Jul 9, 2025

Uh oh!

jkwak-work left a comment

Choose a reason for hiding this comment

Uh oh!

csyonghe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

niklaskorz Jul 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

niklaskorz Jul 30, 2025

Choose a reason for hiding this comment

Uh oh!

gtong-nv Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gtong-nv commented Jul 1, 2025 •

edited

Loading

CLAassistant commented Jul 3, 2025 •

edited

Loading

niklaskorz Jul 30, 2025 •

edited

Loading