Skip to content

Enable Vulkan Validation Layer in CI #7543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gtong-nv merged 7 commits into from
Jun 27, 2025
Merged

Enable Vulkan Validation Layer in CI #7543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5327460
Disable spirv-opt for the tests with debugfunction VVL errors
gtong-nv Jun 25, 2025
c4e1eda
Merge branch 'spirv-opt-debug-info' into enable-vvl
gtong-nv Jun 26, 2025
6fe9fbc
Enable VVL in CI
gtong-nv Jun 26, 2025
47b5b83
Add 2 expected failure tests until we update VVL to 1.4.319 which con…
gtong-nv Jun 26, 2025
afcade4
update slang-rhi
gtong-nv Jun 26, 2025
401c17d
Merge branch 'master' into enable-vvl
gtong-nv Jun 27, 2025
c6100d8
Revert "Disable spirv-opt for the tests with debugfunction VVL errors"
gtong-nv Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,8 @@ jobs:
echo "Checking $api ..." && echo "$smokeResult" | grep -q "Check $api: Supported"
done
echo "Printing CUDA version: ..." && nvcc --version
echo "Printing Vulkan SDK version: ..." && vulkaninfo | grep -i version

fi

if [[ "${{matrix.os}}" == "macos" ]]
Expand All @@ -236,7 +238,7 @@ jobs:
-expected-failure-list tests/expected-failure-github.txt \
-skip-reference-image-generation \
-show-adapter-info \
-enable-debug-layers false
-enable-debug-layers true
else
"$bin_dir/slang-test" \
-use-test-server \
Expand All @@ -245,7 +247,7 @@ jobs:
-expected-failure-list tests/expected-failure-no-gpu.txt \
-skip-reference-image-generation \
-show-adapter-info \
-enable-debug-layers false
-enable-debug-layers true
fi
- name: Run Slang examples
if: steps.filter.outputs.should-run == 'true' && matrix.platform != 'wasm' && matrix.full-gpu-tests
Expand Down
2 changes: 1 addition & 1 deletion external/slang-rhi
Open in desktop
Submodule slang-rhi updated 74 files
+35 −0 .github/workflows/pre-commit.yml
+6 −2 CMakeLists.txt
+92 −1 include/slang-rhi.h
+21 −0 src/core/string.h
+13 −0 src/core/timer.cpp
+50 −0 src/core/timer.h
+2 −2 src/cpu/cpu-device.cpp
+18 −3 src/cpu/cpu-pipeline.cpp
+1 −1 src/cpu/cpu-pipeline.h
+5 −0 src/cpu/cpu-shader-program.cpp
+1 −4 src/cpu/cpu-shader-program.h
+8 −2 src/cuda/cuda-device.cpp
+36 −6 src/cuda/cuda-pipeline.cpp
+2 −2 src/cuda/cuda-pipeline.h
+5 −0 src/cuda/cuda-shader-program.cpp
+1 −4 src/cuda/cuda-shader-program.h
+2 −2 src/d3d11/d3d11-device.cpp
+36 −6 src/d3d11/d3d11-pipeline.cpp
+2 −2 src/d3d11/d3d11-pipeline.h
+2 −2 src/d3d11/d3d11-query.cpp
+1 −1 src/d3d11/d3d11-query.h
+2 −2 src/d3d11/d3d11-shader-program.cpp
+1 −1 src/d3d11/d3d11-shader-program.h
+6 −0 src/d3d12/d3d12-command.cpp
+12 −4 src/d3d12/d3d12-device.cpp
+1 −1 src/d3d12/d3d12-device.h
+92 −57 src/d3d12/d3d12-pipeline.cpp
+3 −3 src/d3d12/d3d12-pipeline.h
+2 −2 src/d3d12/d3d12-shader-program.cpp
+1 −1 src/d3d12/d3d12-shader-program.h
+36 −5 src/debug-layer/debug-device.cpp
+2 −1 src/debug-layer/debug-device.h
+14 −0 src/debug-layer/debug-helper-functions.cpp
+3 −0 src/debug-layer/debug-helper-functions.h
+21 −0 src/device-child.cpp
+3 −7 src/device-child.h
+112 −28 src/device.cpp
+16 −16 src/device.h
+38 −0 src/enum-strings.cpp
+1 −0 src/enum-strings.h
+2 −2 src/metal/metal-device.cpp
+56 −7 src/metal/metal-pipeline.cpp
+4 −2 src/metal/metal-pipeline.h
+2 −2 src/metal/metal-shader-program.cpp
+1 −1 src/metal/metal-shader-program.h
+34 −15 src/pipeline.cpp
+16 −21 src/pipeline.h
+2 −1 src/rhi-shared-fwd.h
+324 −23 src/shader.cpp
+78 −12 src/shader.h
+2 −2 src/staging-heap.h
+18 −0 src/strings.h
+43 −4 src/vulkan/vk-api.h
+57 −28 src/vulkan/vk-command.cpp
+209 −151 src/vulkan/vk-device.cpp
+1 −1 src/vulkan/vk-device.h
+84 −13 src/vulkan/vk-pipeline.cpp
+3 −3 src/vulkan/vk-pipeline.h
+3 −3 src/vulkan/vk-query.cpp
+1 −1 src/vulkan/vk-query.h
+2 −2 src/vulkan/vk-shader-program.cpp
+1 −1 src/vulkan/vk-shader-program.h
+55 −11 src/wgpu/wgpu-pipeline.cpp
+2 −2 src/wgpu/wgpu-pipeline.h
+4 −4 src/wgpu/wgpu-shader-program.cpp
+1 −1 src/wgpu/wgpu-shader-program.h
+23 −13 tests/doctest-reporter.h
+5 −1 tests/main.cpp
+203 −0 tests/test-compilation-report.cpp
+5 −5 tests/test-cooperative-vector.cpp
+1 −4 tests/test-link-time-default.cpp
+57 −0 tests/test-timer.cpp
+50 −5 tests/testing.cpp
+13 −0 tests/testing.h
2 changes: 2 additions & 0 deletions tests/expected-failure-github.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,5 @@ tests/language-feature/shader-params/interface-shader-param-ordinary.slang.4 syn
tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables.slang.8 (mtl)
tests/glsl-intrinsic/shader-subgroup/shader-subgroup-builtin-variables-2.slang.3 (mtl)
tests/compute/cbuffer-legalize.slang.2 syn (mtl)
tests/cooperative-vector/matrix-mul-bias-packed.slang (vk)
tests/cooperative-vector/matrix-mul-bias-packed-mut.slang (vk)
Loading