Fix incorrect CMAKE define SLANG_ENABLE_IR_BREAK_ALLOC,#7418
Merged
ArielG-NV merged 3 commits intoshader-slang:masterfrom Jun 12, 2025
Merged
Fix incorrect CMAKE define SLANG_ENABLE_IR_BREAK_ALLOC,#7418ArielG-NV merged 3 commits intoshader-slang:masterfrom
SLANG_ENABLE_IR_BREAK_ALLOC,#7418ArielG-NV merged 3 commits intoshader-slang:masterfrom
Conversation
fixes: shader-slang#7417 Define was called `SLANG_ENABLE_IR_BREAK_ALLOC,`. This is incorrect, supposed to be `SLANG_ENABLE_IR_BREAK_ALLOC`.
ArielG-NV
changed the title
SLANG_ENABLE_IR_BREAK_ALLOCSLANG_ENABLE_IR_BREAK_ALLOC,
gtong-nv
approved these changes
Jun 11, 2025
Contributor
gtong-nv
left a comment
gtong-nv
left a comment
There was a problem hiding this comment.
LGTM.
Interestingly, I've been using the vs2022-dev preset and was able to get the debug assisting features (Like the "_debugUID") with this define set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #7417
Define was called
SLANG_ENABLE_IR_BREAK_ALLOC,. This is incorrect, supposed to beSLANG_ENABLE_IR_BREAK_ALLOC. Without this change, this define does nothing.