Enable some float3 cbuffer tests#7391
Merged
jhelferty-nv merged 3 commits intoshader-slang:masterfrom Jun 12, 2025
Merged
Conversation
Results of these tests had been marked ignored, because they failed on VK with the GLSL backend. This change removes them from the expected-failure.txt file and adds the correct commandline option to avoid using the GLSL target.
jhelferty-nv
changed the title
jhelferty-nv
changed the title
kaizhangNV
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address testing issue raised on PR #7282.
Results of these tests had been marked ignored, because they failed on VK with the GLSL target. This change removes them from the expected-failure.txt file and adds the correct command line option to avoid using the GLSL target and only use SPIRV.