Fix intermittent debug failures with Debug build#7369
Fix intermittent debug failures with Debug build#7369jkwak-work merged 5 commits intoshader-slang:masterfrom
Conversation
e4e4487 to
c99f277
Compare
|
With this fix,
When failures are observed on "linux/release/gcc", the following test failed. When failures are observed on "macos/release/clang", the following tests failed, Note that without this fix, the failure rate of linux and macos wasn't 0%. You can find more information here. |
This reverts commit 7f6b683. And keep the test-server count at 8
c99f277 to
6702935
Compare
|
closes #7333 |
|
I agree that the RAII style is better. But I don't understand how it helps the intermittent assert... It's always disable first, and then enable again. |
This PR replaces enable/disable style C function calls with C++ RAII style code.
In debug build, when an assertion failed in between enable and disable functions, an exception is thrown and the disable function is not called. RAII style code is safer for an exception