Skip to content

Fix wasm releases #7313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csyonghe merged 4 commits into from
Jun 19, 2025
Merged

Fix wasm releases #7313

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10d3b84
Update ci.yml
eliemichel Jun 3, 2025
b000476
Update ci.yml
eliemichel Jun 3, 2025
df2e22a
Merge branch 'master' into eliemichel/fix-wasm-releases
szihs Jun 4, 2025
f0707e5
Merge branch 'master' into eliemichel/fix-wasm-releases
csyonghe Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,4 +297,6 @@ jobs:
with:
name: slang-build-${{matrix.os}}-${{matrix.platform}}-${{matrix.compiler}}-${{matrix.config}}
# The install directory used in the packaging step
path: build/dist-${{matrix.config}}/**/ZIP/slang/*
path: |
build/dist-${{matrix.config}}/**/ZIP/slang/*
build.em/Release
Copy link
Copy Markdown
Collaborator

@csyonghe csyonghe Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include every file under this directory? Are there any files we want to exclude or this is just to pickup libslang.a?

Copy link
Copy Markdown
Contributor Author

@eliemichel eliemichel Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can see in the resulting artifact, this directory exclusively contains the bin/lib/include files we can expect from a release. That's probably where the workflow cmake install-ed compiled assets.

Loading