Add CoopVec load/store pointer overloads#6822
Merged
fairywreath merged 10 commits intoshader-slang:masterfrom May 23, 2025
Merged
Add CoopVec load/store pointer overloads#6822fairywreath merged 10 commits intoshader-slang:masterfrom
fairywreath merged 10 commits intoshader-slang:masterfrom
Conversation
csyonghe
reviewed
Apr 15, 2025
| int32_t* ptr; | ||
| } | ||
|
|
||
| //TEST_INPUT:ubuffer(data=[1 2 3 4 5 6 7 8], stride=4),name=buf |
Collaborator
There was a problem hiding this comment.
ptr isn't initialized with anything that is actually valid to read/write to.
TEST_INPUT allows you to assign a ubuffer to a pointer value, can you try that instead and turn this into an executable test?
Collaborator
There was a problem hiding this comment.
e.g.
//TEST_INPUT: set pObj = ubuffer(data=[2 0 0 0], stride=4);
uniform Obj* pObj;
Contributor
Author
There was a problem hiding this comment.
Thanks - is it possible to have these as output?
Collaborator
There was a problem hiding this comment.
Should be? I haven’t tried that yet…
csyonghe
approved these changes
May 23, 2025
Collaborator
|
I think we also need overloads of coopMatMulAdd and friends that takes pointers for the matrix instead of a ByteAddressBuffer + offset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CoopVec load/store function overloads to accept
Ptrtypes. SPIRV accepts the pointers as pointers to an array of scalars/vectors. Hence the user's pointer-to-scalar must be translated to a pointer-to-array, more specifically a runtime/unsized array, where astridedecoration is required.