Fix issue in peepholeOptimize #6543
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizhangNV
changed the title
Close shader-slang#6541. When calculating the field index during peepholeOptimize, we should not count the field which is void type, because we don't use that field when calling makeStruct.
csyonghe
reviewed
Mar 8, 2025
| @@ -402,6 +402,10 @@ struct PeepholeContext : InstPassBase | |||
| Index i = 0; | |||
| for (auto sfield : structType->getFields()) | |||
| { | |||
| if (as<IRVoidType>(sfield->getFieldType()) && | |||
There was a problem hiding this comment.
It seems the problem is not with peephole optimization, but the code that results the consistency between struct type and make struct. Whenever we remove the void field from the struct type, we also need to update all make struct insts to keep consistent.
|
We need to find the pass that causes inconsistency between make struct and struct type, and make sure we never violate the invariant that make struct has the same number of operands as the number of struct fields. |
kaizhangNV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6541.
When calculating the field index during peepholeOptimize, we should not count the field which is void type, because we don't use that field when calling makeStruct.