Use coopvec supporting dxcompiler dll #6302
Draft
+47
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Falcor is also failing. I need to investigate |
jkwak-work
force-pushed
the
use_coopvec_supporting_dxcompiler_dll_and_three_test_failures
branch
from
683bf8a to
0cc097c
Compare
jkwak-work
changed the title
jkwak-work
force-pushed
the
use_coopvec_supporting_dxcompiler_dll_and_three_test_failures
branch
from
0cc097c to
69989cf
Compare
jkwak-work
force-pushed
the
use_coopvec_supporting_dxcompiler_dll_and_three_test_failures
branch
from
406172c to
6121b1e
Compare
This commit is to experiment the idea of what would happen if we deduplicate the witness table based only on its type and its first operand. It turned out that it causes a crash, because it doesn't carry the decorations and childs properly. It means we need to also consider them as well as its type and its first operand. But if we do, we cannot deduplicate anything. It seems that this is not the right place to apply the deduplication.
jkwak-work
force-pushed
the
use_coopvec_supporting_dxcompiler_dll_and_three_test_failures
branch
from
6121b1e to
1dbf102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses dxcompiler.dll and dxil.dll that is built from:
https://github.com/NVIDIA-RTX/DirectXShaderCompiler/tree/CooperativeVector
Related to #6250