Deprecate operator & for getting addresses#10206
Draft
aidanfnv wants to merge 6 commits intoshader-slang:masterfrom
Draft
Deprecate operator & for getting addresses#10206aidanfnv wants to merge 6 commits intoshader-slang:masterfrom
& for getting addresses#10206aidanfnv wants to merge 6 commits intoshader-slang:masterfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
For clarification, is this deprecating overloading support for this particular operator, or just addressing of arbitrary L-values? Full removal would be a bit unfortunate since it's not that uncommon that I write code like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prefix
&operator for taking addresses has unclear semantics on GPU targets and is not intended to be part of the Slang language going forward.This change adds an unconditional error (30086: "the '&' operator for taking addresses is no longer supported in Slang") when the resolved function has
KnownBuiltinDeclName::OperatorAddressOf, emitted fromCheckInvokeExprWithCheckedOperands. Theoperator&declaration itself is unchanged. Internal code uses__getAddressinstead.