Initialize slang capabilities#596
Conversation
jkwak-work
left a comment
jkwak-work
left a comment
There was a problem hiding this comment.
I didn't know that slang-rhi has a list of capability.
Does it mean we should modify slang-rhi side include/slang-rhi/capabilities.h whenever we changes the capability on Slang repo?
I opened shader-slang/slang#7005 for that. It would be neat if slang shipped with a header file defining all available capabilities. Currently I have to update that list manually .. |
skallweitNV
force-pushed
the
dev/skallweit/initialize-capabilities
branch
from
2fb6571 to
5272fb0
Compare
ccummingsNV
left a comment
ccummingsNV
left a comment
There was a problem hiding this comment.
Minor comment, but otherwise LGTM
| if (m_ctx.optixContext->getCooperativeVectorSupport()) | ||
| { | ||
| addFeature(Feature::CooperativeVector); | ||
| // addCapability(Capability::optix_coopvec); |
There was a problem hiding this comment.
Not clear to me why this is here but commented out - maybe delete or say why?
There was a problem hiding this comment.
Good point. This is commented out because when setting that capability in a session that is used to compile a compute kernel it fails in slang. Guess the reason is that this capability is invalid in a compute/CUDA-only context, but why slang doesn't just ignore it is to be answered. Because there are other capabilities that have no meaning in certain entry point types for example, which all seem to work fine.
3 participants
No description provided.