Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tanstack): fix paths value in tsconfig and check for tanstack start in devDeps also #6590

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

prateekkumarweb
Copy link
Contributor

I tried the shadcn tanstack start guide with tailwindcss v4. Found two issues. One was incorrect paths in tsconfig and another being tanstack start is not detected if it is present as dev dependency. Fixed those.

Copy link

vercel bot commented Feb 7, 2025

@prateekkumarweb is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 6:16am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ui ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 6:16am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@shadcn shadcn merged commit 16d4d38 into shadcn-ui:main Feb 7, 2025
8 checks passed
@prateekkumarweb prateekkumarweb deleted the fix-docs branch February 7, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants