Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): fix missing value on the progress component #2397

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LarsJK
Copy link

@LarsJK LarsJK commented Jan 12, 2024

The value property of ProgressPrimitive.Root was not set. So screen readers will not read the actual value of the progress indicator.

Copy link

vercel bot commented Jan 12, 2024

@LarsJK is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@dan5py
Copy link
Contributor

dan5py commented Jan 12, 2024

Hi @LarsJK, you forgot to build the registry. Please take a look at the CONTRIBUTING file here.

Thank you.

@LarsJK
Copy link
Author

LarsJK commented Jan 12, 2024

@dan5py The build fails. Running into this #1926

@LarsJK
Copy link
Author

LarsJK commented Jan 12, 2024

Did the mentioned workaround with tsx.

@pruett
Copy link

pruett commented Jun 23, 2024

Came here to make the same change. This update correctly sets the [data-state] attribute as it is currently "indeterminate"

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants