fix(build): replace ts-node with tsx to resolve issues with modules #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Gravy59 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
shadcn
approved these changes
Jan 28, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # pnpm-lock.yaml
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
…hadcn-ui#1977) This pull request resolves shadcn-ui#1926 and prevents issues like it from happening in the future ## Rationale for this PR This PR changes the TypeScript execution package for use in scripts like `build:registry` from `ts-node` to `tsx`. This is because `ts-node` has many difficult quirks to work through (and is slow). In addition, it also has a difficult to understand error for newcomers that *is* reproducible. ### The ts-node error As shown in shadcn-ui#1926, using `ts-node` (specifically in `build:registry`) results in this error: `Unknown file extension ".ts" for /ui/apps/www/scripts/build-registry.ts`. There are many issues in the `ts-node` repository documenting this problem: * TypeStrong/ts-node/issues/1062 * TypeStrong/ts-node/issues/2033 * TypeStrong/ts-node/issues/1997 Switching the typescript-in-node system to `tsx`, which uses esbuild under the hood, resolves this error. This PR shouldn't affect tests, representation, etc. and is merely a change of build tools. There is no urgent need to merge this. I accidentally deleted the head repository on shadcn-ui#1937. That will not happen again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1926 and prevents issues like it from happening in the future
Rationale for this PR
This PR changes the TypeScript execution package for use in scripts like
build:registryfromts-nodetotsx. This is becausets-nodehas many difficult quirks to work through (and is slow). In addition, it also has a difficult to understand error for newcomers that is reproducible.The ts-node error
As shown in #1926, using
ts-node(specifically inbuild:registry) results in this error:Unknown file extension ".ts" for /ui/apps/www/scripts/build-registry.ts. There are many issues in thets-noderepository documenting this problem:Switching the typescript-in-node system to
tsx, which uses esbuild under the hood, resolves this error.This PR shouldn't affect tests, representation, etc. and is merely a change of build tools. There is no urgent need to merge this.
I accidentally deleted the head repository on #1937. That will not happen again.