fix: updated error msg for jsconfig in cli #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KMJ-007 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
RichardIshimwe
approved these changes
Oct 8, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
* fix: updated error msg for jsconfig in cli * chore: add changeset * style(cli): format --------- Co-authored-by: shadcn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
came across this bug when was trying to use ui lib for js project,
my project didn't hade jsconfig, was confused what to do, error was saying tsconfig but my whole project didn't have single ts file, better error msg should have help me
i tried to look into test file, but was not able to figure out how to write test for this, which covers this specific edge case, need some help
cloese #1566