Support tailwind.config.ts #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukahartwig is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
m1nsuplee
reviewed
Aug 23, 2023
|
No updates on this yet? |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
We need a changeset here. I'll add one. |
kjxbyz
pushed a commit
to muse-ui/muse-ui
that referenced
this pull request
Jun 7, 2024
Fixes shadcn-ui#659 Fixes shadcn-ui#633 Create Next App is using `tailwind.config.ts` in the TypeScript template. Since this is a very common use case it would be nice to preserve the type safety of the file. I added new templates for TypeScript files. I see there is an issue shadcn-ui#1073 which asks for ESM support as well. This is not included in this PR. I also fixed the type error in the keyframes that is also handled in shadcn-ui#636
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #659
Fixes #633
Create Next App is using
tailwind.config.tsin the TypeScript template. Since this is a very common use case it would be nice to preserve the type safety of the file.I added new templates for TypeScript files. I see there is an issue #1073 which asks for ESM support as well. This is not included in this PR.
I also fixed the type error in the keyframes that is also handled in #636