[bug]: css var destructive-foreground is same color as destructive
#6832
Labels
bug
Something isn't working
Comments
|
Hello Same here ? 😔 |
|
I'll make a PR for this fix |
Jacksonmills
added a commit
to Jacksonmills/ui
that referenced
this issue
Mar 4, 2025
…erlap Changes the `destructive-foreground` CSS variable to the correct color to prevent it from matching the `destructive` color, ensuring better visual differentiation. Fixes shadcn-ui#6832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
In a recent commit #6693 the
destructive-foregroundcolor was changed to red, which is the same color asdestructive. This makes it impossible to see the text in destructive buttons or other elements using those variables.Affected component/components
Button
How to reproduce
Add a button element to the page and notice how the text is not visible at all. This only applies in light mode.
Codesandbox/StackBlitz link
No response
Logs
System Info
Before submitting
The text was updated successfully, but these errors were encountered: