Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fir for autocomplete and stepper #114

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Minor fir for autocomplete and stepper #114

merged 3 commits into from
Dec 16, 2021

Conversation

anitnilay20
Copy link
Contributor

PR Details

Description

  • Add keywords mode to auto complete.
  • Change selected style for multiple and keywords mode.
  • Update stepper component.
  • Remove Carousel from stepper.
  • Remove Children props from stepper.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Remove Carousel from stepper.
* Remove Children props from stepper.
* Change selected style for multiple and keywords mode.
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #114 (72967c6) into master (fe6d346) will decrease coverage by 0.59%.
The diff coverage is 100.00%.

❗ Current head 72967c6 differs from pull request most recent head 9aa96fe. Consider uploading reports for the commit 9aa96fe to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   90.39%   89.79%   -0.60%     
==========================================
  Files         139      139              
  Lines        2196     2195       -1     
  Branches      524      526       +2     
==========================================
- Hits         1985     1971      -14     
- Misses        211      224      +13     
Impacted Files Coverage Δ
src/components/AutoComplete/AutoComplete.tsx 100.00% <100.00%> (+0.79%) ⬆️
src/components/Stepper/Stepper.tsx 97.82% <100.00%> (-0.10%) ⬇️
src/components/Tag/Tag.tsx 100.00% <100.00%> (ø)
src/components/Tooltip/Tooltip.tsx 100.00% <100.00%> (ø)
src/components/Carousel/Carousel.tsx 23.07% <0.00%> (-53.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe6d346...9aa96fe. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant