Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Test cases for Transfer and minor fix. #100

Merged
merged 4 commits into from
Nov 21, 2021
Merged

Conversation

prateekshourya29
Copy link
Contributor

PR Details

Description

  • Remove Search functionality.
  • Convert transfer to functional Component.
  • Fix transfer storybook issue.
  • Set data, values, onChange props as required.
  • Add test case for Transfer.

Related Issue

#39

Motivation and Context

For 100% test coverage.

How Has This Been Tested

Tested using jest with the help of react testing library.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #100 (32199fe) into master (129de2d) will increase coverage by 2.84%.
The diff coverage is 100.00%.

❗ Current head 32199fe differs from pull request most recent head c0b8423. Consider uploading reports for the commit c0b8423 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
+ Coverage   87.54%   90.39%   +2.84%     
==========================================
  Files         139      139              
  Lines        2224     2196      -28     
  Branches      557      556       -1     
==========================================
+ Hits         1947     1985      +38     
+ Misses        276      211      -65     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/components/Transfer/Transfer.tsx 100.00% <100.00%> (+87.50%) ⬆️
src/components/Card/CardHeader.tsx 100.00% <0.00%> (+27.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 129de2d...c0b8423. Read the comment docs.

@anitnilay20 anitnilay20 merged commit 7e2c469 into master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants