fix: decouple spec discovery from --detail flag, fix step numbering - #1
Open
fsmw wants to merge 1 commit into
Conversation
CodeRabbit's review of Fission-AI#902 flagged two issues. This commit addresses both so the PR can merge before or independent of Fission-AI#700: - Critical: the discovery prompt assumed `openspec list --specs --json --detail` returns title/overview/requirementCount, but the current CLI only emits id and requirementCount. --detail lands in Fission-AI#700. Replace the prompt with a fallback: prefer --detail when available, otherwise read the `## Purpose` section of each `openspec/specs/<id>/spec.md`. Applies to propose, ff, and continue workflows (both skill and command templates). - Minor: renumber "5. Show final status" to "6." in propose and ff workflows after the inserted discovery step bumped everything by one. Updated skill-template parity test hashes for the modified templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses both CodeRabbit review items from Fission-AI#902:
--detailnot yet available. The discovery prompt assumedopenspec list --specs --json --detailreturnstitle/overview/requirementCount, but the current CLI only emitsidandrequirementCount.--detaillands in feat: list cmd support json for specs and archive Fission-AI/OpenSpec#700 (still open). The prompt now prefers--detailwhen available and falls back to reading the## Purposesection of eachopenspec/specs/<id>/spec.md. Applied to propose, ff, and continue workflows (both skill and command templates).pnpm test test/core/templates/,pnpm lint, andpnpm exec tsc --noEmitall pass. Skill-template parity test hashes updated.This version no longer blocks on Fission-AI#700. If Fission-AI#700 lands later, the prompt can prefer the structured fields automatically (it already checks).
See Fission-AI#901 for the original request.