Fix code and tests on windows. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
force-pushed
the
fix_test_on_windows
branch
from
8c32995
to
385213f
Compare
Given that I absolutely don't care about windows, this fixes code and tests on it. PR #21 tried to set the PATH env var in an unix like way with the effect of disabling the go test execution without an error code. This patch: * Fixes PATH env to add $GOPATH/bin * Fixes isParentDirectory * Fixes TestGetLastVendorPath and TestIsParentDirectory * Handles missing error check on `glide list` execution
sgotti
force-pushed
the
fix_test_on_windows
branch
from
385213f
to
c738841
Compare
|
Oops, sorry about that. LGTM! |
|
@Fugiman Thanks and don't worry. It's a mess handling different path separators between package paths and os paths. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that I absolutely don't care about windows, this fixes code and tests on
it.
PR #21 tried to set the PATH env var in an unix like way with the effect of
disabling the go test execution.
This patch:
glide listexecution/cc @Fugiman