Skip to content

test: negative value testing for frequency, presence penalizers #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ying1123 merged 1 commit into from
Aug 9, 2024
Merged

test: negative value testing for frequency, presence penalizers #995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions test/srt/sampling/penaltylib/penalizers/test_frequency_penalty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,16 @@
Subject,
)

FREQUENCY_PENALTY = 0.12


class TestBatchedFrequencyPenalizer(BaseBatchedPenalizerTest):
class BaseBatchedFrequencyPenalizerTest(BaseBatchedPenalizerTest):
Penalizer = BatchedFrequencyPenalizer
frequency_penalty: float

def setUp(self):
if self.__class__ == BaseBatchedFrequencyPenalizerTest:
self.skipTest("Base class for frequency_penalty tests")

super().setUp()

def _create_subject(self, frequency_penalty: float) -> Subject:
return Subject(
Expand Down Expand Up @@ -72,9 +77,17 @@ def _create_subject(self, frequency_penalty: float) -> Subject:
)

def create_test_subjects(self) -> typing.List[Subject]:
self.enabled = self._create_subject(frequency_penalty=FREQUENCY_PENALTY)
self.enabled = self._create_subject(frequency_penalty=self.frequency_penalty)
self.disabled = self._create_subject(frequency_penalty=0.0)


class TestBatchedFrequencyPenalizerPositiveValue(BaseBatchedFrequencyPenalizerTest):
frequency_penalty = 0.12


class TestBatchedFrequencyPenalizerNegativeValue(BaseBatchedFrequencyPenalizerTest):
frequency_penalty = -0.12


if __name__ == "__main__":
unittest.main()
21 changes: 17 additions & 4 deletions test/srt/sampling/penaltylib/penalizers/test_presence_penalty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,16 @@
Subject,
)

PRESENCE_PENALTY = 0.12


class TestBatchedPresencePenalizer(BaseBatchedPenalizerTest):
class BaseBatchedPresencePenalizerTest(BaseBatchedPenalizerTest):
Penalizer = BatchedPresencePenalizer
presence_penalty: float

def setUp(self):
if self.__class__ == BaseBatchedPresencePenalizerTest:
self.skipTest("Base class for presence_penalty tests")

super().setUp()

def _create_subject(self, presence_penalty: float) -> Subject:
return Subject(
Expand Down Expand Up @@ -72,9 +77,17 @@ def _create_subject(self, presence_penalty: float) -> Subject:
)

def create_test_subjects(self) -> typing.List[Subject]:
self.enabled = self._create_subject(presence_penalty=PRESENCE_PENALTY)
self.enabled = self._create_subject(presence_penalty=self.presence_penalty)
self.disabled = self._create_subject(presence_penalty=0.0)


class TestBatchedPresencePenalizerPositiveValue(BaseBatchedPresencePenalizerTest):
presence_penalty = 0.12


class TestBatchedPresencePenalizerNegativeValue(BaseBatchedPresencePenalizerTest):
presence_penalty = -0.12


if __name__ == "__main__":
unittest.main()