Skip to content

support for interns1-mini - #9299

Merged
zhyncs merged 4 commits into
sgl-project:mainfrom
CUHKSZzxy:interns1-mini
Aug 19, 2025
Merged

support for interns1-mini#9299
zhyncs merged 4 commits into
sgl-project:mainfrom
CUHKSZzxy:interns1-mini

Conversation

@CUHKSZzxy

Copy link
Copy Markdown
Contributor

For the coming InternS1-mini model.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @CUHKSZzxy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for the upcoming InternS1-mini model. The core changes involve integrating Qwen3ForCausalLM as the language model backend for the InternS1 architecture. This is achieved by adding conditional logic to load the Qwen3ForCausalLM within the InternS1Model constructor. Additionally, a minor adjustment was made to the get_input_embeddings method in qwen3.py to streamline its signature.

Highlights

  • InternS1-mini Model Support: Added the necessary import and instantiation logic within interns1.py to allow the InternS1Model to utilize Qwen3ForCausalLM as its underlying language model component.
  • Qwen3 get_input_embeddings Method Update: Refactored the get_input_embeddings method in qwen3.py by removing the input_ids parameter, simplifying its interface and potentially aligning it with a new usage pattern.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the interns1-mini model. The changes primarily involve:

  1. In interns1.py, adding logic to handle Qwen3ForCausalLM as a language model option.
  2. In qwen3.py, fixing the get_input_embeddings method signature in Qwen3ForCausalLM to align with its usage, which would have otherwise caused a TypeError.

The changes look good and are necessary for the new model support. I have one minor suggestion to improve type hint consistency in qwen3.py.

Comment thread python/sglang/srt/models/qwen3.py Outdated
JustinTong0323 and others added 2 commits August 18, 2025 15:40
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@JustinTong0323 JustinTong0323 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhyncs
zhyncs merged commit a31ea44 into sgl-project:main Aug 19, 2025
9 of 48 checks passed
@CUHKSZzxy
CUHKSZzxy deleted the interns1-mini branch August 19, 2025 10:14
MahmoudAshraf97 pushed a commit to MahmoudAshraf97/sglang that referenced this pull request Sep 8, 2025
0826joyce pushed a commit to 0826joyce/sglang-perf-opt that referenced this pull request May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants