support for interns1-mini - #9299
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @CUHKSZzxy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for the upcoming InternS1-mini model. The core changes involve integrating Qwen3ForCausalLM as the language model backend for the InternS1 architecture. This is achieved by adding conditional logic to load the Qwen3ForCausalLM within the InternS1Model constructor. Additionally, a minor adjustment was made to the get_input_embeddings method in qwen3.py to streamline its signature.
Highlights
- InternS1-mini Model Support: Added the necessary import and instantiation logic within
interns1.pyto allow theInternS1Modelto utilizeQwen3ForCausalLMas its underlying language model component. - Qwen3
get_input_embeddingsMethod Update: Refactored theget_input_embeddingsmethod inqwen3.pyby removing theinput_idsparameter, simplifying its interface and potentially aligning it with a new usage pattern.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds support for the interns1-mini model. The changes primarily involve:
- In
interns1.py, adding logic to handleQwen3ForCausalLMas a language model option. - In
qwen3.py, fixing theget_input_embeddingsmethod signature inQwen3ForCausalLMto align with its usage, which would have otherwise caused aTypeError.
The changes look good and are necessary for the new model support. I have one minor suggestion to improve type hint consistency in qwen3.py.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
For the coming InternS1-mini model.