Conversation
zhyncs
approved these changes
Aug 2, 2024
Contributor
Author
|
move to #899 |
efschu
pushed a commit
to efschu/htsglang
that referenced
this pull request
Aug 26, 2026
…failure bodies determined, and the directory nobody's gate watched) into the flip train
efschu
pushed a commit
to efschu/htsglang
that referenced
this pull request
Aug 26, 2026
…own merges moved The merge-regression run over the day's ticket suites turned up exactly one failure outside the recorded standing set: test_rejected_evidence_pins.py::PpWithSpecEvidenceTest:: test_evidence_cites_land_on_BOTH_halves_of_the_guard. Not a defect in any merged fix. sgl-project#898 re-pinned this row against be56c4e, and the same day's server_args.py additions -- sgl-project#889, sgl-project#893, sgl-project#894, sgl-project#897 and sgl-project#887/sgl-project#890 -- then pushed the guard down 44 lines. The verdict did not change; its coordinates did. :19436/:19451 -> :19480/:19495, both re-read in the merged tree rather than taken from the failure text. This is the guard doing its job: a line pin is a coordinate into a file other tickets edit, so it goes stale at MERGE time, not at write time, and only a train run can see it. #704b re-pinned the same row for the same reason, so the note now says so instead of reading as a one-off. CLASS. test_rejected_evidence_pins.py is the only line-pin validator in the tree (grep for _LINE_REF / "cite has drifted"), and its other five cases pass, so no sibling pin drifted unseen behind a missing guard. 6 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.