Skip to content

[CI] fix pip upgrade #8881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 1 commit into from
Aug 6, 2025
Merged

[CI] fix pip upgrade #8881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/ci_install_dependency.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ fi

# Update pip
if [ "$MODE_BLACKWELL" != "1" ]; then
pip install --upgrade pip --break-system-packages
pip install --upgrade pip
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better maintainability, it would be helpful to add a comment explaining why --break-system-packages is omitted for this specific pip command, while it's used for subsequent ones. This is likely because the pre-upgrade pip version might not support this flag, and adding this context will help future contributors understand the reasoning.

Suggested change
pip install --upgrade pip
# --break-system-packages is omitted here as the initial pip version might not support it.
pip install --upgrade pip

fi

# Clean up existing installations
Expand Down
Loading