Skip to content

chore: upgrade torch 2.8.0 #8836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhyncs merged 4 commits into from
Aug 6, 2025
Merged

chore: upgrade torch 2.8.0 #8836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ade3007
chore: upgrade torch 2.8.0
zhyncs Aug 5, 2025
995329c
upd
zhyncs Aug 5, 2025
70cdb5f
upd
zhyncs Aug 5, 2025
caa820f
upd
zhyncs Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/vllm-dependency-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ jobs:

- name: Install dependencies
run: |
bash scripts/ci_install_dependency.sh
pip install "vllm==0.10.0"
pip install "bitsandbytes>=0.44.0"
bash scripts/ci_install_dependency.sh

- name: Run VLLM dependency tests
timeout-minutes: 60
Expand Down
16 changes: 8 additions & 8 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ name = "sglang"
version = "0.4.10.post2"
description = "SGLang is yet another fast serving framework for large language models and vision language models."
readme = "README.md"
requires-python = ">=3.8"
requires-python = ">=3.9"
license = { file = "LICENSE" }
classifiers = [
"Programming Language :: Python :: 3",
Expand Down Expand Up @@ -54,10 +54,10 @@ runtime_common = [

srt = [
"sglang[runtime_common]",
"sgl-kernel==0.2.8",
"torch==2.7.1",
"torchaudio==2.7.1",
"torchvision==0.22.1",
"sgl-kernel==0.3.2",
"torch==2.8.0",
"torchaudio==2.8.0",
"torchvision",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

torchvision is unpinned, which can lead to non-reproducible builds. It's recommended to pin it to a specific version compatible with torch==2.8.0. For example, torchvision==0.23.0 seems to be available on the PyTorch test channel. This would also make it consistent with the blackwell dependency group which has a pinned version (though that one also needs an update).

"torchvision==0.23.0",

"cuda-python",
"einops",
"flashinfer_python==0.2.10",
Expand All @@ -66,9 +66,9 @@ srt = [
blackwell = [
"sglang[runtime_common]",
"sgl-kernel",
"torch==2.7.1",
"torchaudio==2.7.1",
"torchvision==0.22.1",
"torch==2.8.0",
"torchaudio==2.8.0",
Comment on lines +69 to +70
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While torch and torchaudio are upgraded to 2.8.0, torchvision on the next line is kept at 0.22.1, which is likely incompatible. This can cause installation or runtime errors. Please update torchvision to a compatible version. This is also inconsistent with the srt dependency group where torchvision is unpinned.

"torchvision",
"cuda-python",
"einops",
"flashinfer_python==0.2.10",
Expand Down
2 changes: 1 addition & 1 deletion python/sglang/srt/entrypoints/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ def _set_envs_and_config(server_args: ServerArgs):
if _is_cuda:
assert_pkg_version(
"sgl-kernel",
"0.2.8",
"0.3.2",
"Please reinstall the latest version with `pip install sgl-kernel --force-reinstall`",
)

Expand Down
2 changes: 1 addition & 1 deletion scripts/ci_install_dependency.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ rm -rf /usr/local/lib/python3.10/dist-packages/flashinfer*
rm -rf /usr/local/lib/python3.10/dist-packages/sgl_kernel*

# Install the main package
pip install -e "python[dev]"
pip install -e "python[dev]" --extra-index-url https://download.pytorch.org/whl/test/cu126

# Show current packages
pip list
Expand Down
Loading