Skip to content

[AMD] Pull latest SGLang version for AMD CI#8787

Merged
zhyncs merged 4 commits intosgl-project:mainfrom
quitenode:amd-ci-version
Aug 7, 2025
Merged

[AMD] Pull latest SGLang version for AMD CI#8787
zhyncs merged 4 commits intosgl-project:mainfrom
quitenode:amd-ci-version

Conversation

@quitenode
Copy link
Copy Markdown

@quitenode quitenode commented Aug 5, 2025

Motivation

Enhance amd_ci_start_container.sh to dynamically retrieve SGLang version from version.py, with a fallback option. Update default base tags for MI30X and MI35X to use the retrieved version.

Continue of #8070

Modifications

Accuracy Test

Benchmark & Profiling

Checklist

…ion from version.py, with a fallback option. Update default base tags for MI30X and MI35X to use the retrieved version.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @michael-amd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've updated the amd_ci_start_container.sh script to dynamically retrieve the SGLang version from version.py. This change ensures that the CI process for AMD platforms (MI30X and MI35X) always uses the correct and up-to-date SGLang version for its base tags, improving consistency and reducing manual updates.

Highlights

  • Dynamic Version Retrieval: The amd_ci_start_container.sh script now includes logic to read the SGLang version directly from python/sglang/version.py.
  • Version Extraction Logic: A Python one-liner is used within the shell script to parse version.py and extract the __version__ string using regular expressions.
  • Fallback Mechanism: A fallback version (v0.4.10.post2) is provided in case version.py is not found or the version cannot be extracted, ensuring the script remains functional.
  • Updated Base Tags: The DEFAULT_MI30X_BASE_TAG and DEFAULT_MI35X_BASE_TAG variables are now constructed using the dynamically retrieved SGLang version, replacing hardcoded values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@quitenode quitenode changed the title [AMD] Dynamically retrieve SGLang version for AMD CI [AMD] Pull latest SGLang version for AMD CI Aug 5, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances the AMD CI script to dynamically retrieve the SGLang version, which is a good improvement over hardcoded values. My review focuses on making the version retrieval logic more robust and maintainable by addressing potential issues like duplicated code and silent fallbacks. The suggested changes will improve the script's reliability.

michaelzhang-ai and others added 2 commits August 4, 2025 21:43
…l logic. Introduce a fallback mechanism for version parsing and enhance error handling for missing version.py file.
@quitenode
Copy link
Copy Markdown
Author

https://github.com/sgl-project/sglang/actions/runs/16742434839/job/47393424059?pr=8787

Run bash scripts/amd_ci_start_container.sh
Using SGLang version: v0.4.10.post2
Extracted runner from hostname: linux-mi325-gpu-1
The runner is: linux-mi325-gpu-1
Runner is linux-mi325-gpu-1, will find mi30x image.
Checking for image: rocm/sgl-dev:v0.4.10.post2-rocm630-mi30x-20250805
Found available image: rocm/sgl-dev:v0.4.10.post2-rocm630-mi30x-20250805
Pulling Docker image: rocm/sgl-dev:v0.4.10.post2-rocm630-mi30x-20250805
v0.4.10.post2-rocm630-mi30x-20250805: Pulling from rocm/sgl-dev

@quitenode
Copy link
Copy Markdown
Author

Hi @saienduri, could I ask how to know current rocm version for mi30x and mi35x so I will remove the hard code rocm version?

@saienduri
Copy link
Copy Markdown
Collaborator

Okay to use hardcoded rocm version

@quitenode
Copy link
Copy Markdown
Author

quitenode commented Aug 6, 2025

@saienduri could you help to approve? cc: @HaiShaw

Okay to use hardcoded rocm version

@zhyncs zhyncs merged commit 4f2e149 into sgl-project:main Aug 7, 2025
57 of 64 checks passed
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

narutolhy pushed a commit to narutolhy/sglang that referenced this pull request Aug 17, 2025
MahmoudAshraf97 pushed a commit to MahmoudAshraf97/sglang that referenced this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants