Skip to content

[bugfix] Fix 2 minor bugs in the hicache storage layer #8404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025
Merged

[bugfix] Fix 2 minor bugs in the hicache storage layer #8404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions examples/monitoring/grafana/dashboards/json/sglang-dashboard.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
"hide": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "P95",
"legendFormat": "P50",
"range": true,
"refId": "C",
"useBackend": false
Expand All @@ -164,7 +164,7 @@
"hide": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "P50",
"legendFormat": "Avg",
"range": true,
"refId": "D",
"useBackend": false
Expand Down Expand Up @@ -393,7 +393,7 @@
"hide": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "P95",
"legendFormat": "P50",
"range": true,
"refId": "C",
"useBackend": false
Expand All @@ -405,12 +405,12 @@
},
"disableTextWrap": false,
"editorMode": "code",
"expr": "avg(rate(sglang:time_to_first_token_seconds_bucket[$__rate_interval]) / rate(sglang:time_to_first_token_seconds_bucket[$__rate_interval]))\r\n",
"expr": "avg(rate(sglang:time_to_first_token_seconds_sum[$__rate_interval]) / rate(sglang:time_to_first_token_seconds_count[$__rate_interval]))\r\n",
"fullMetaSearch": false,
"hide": false,
"includeNullMetadata": true,
"instant": false,
"legendFormat": "P50",
"legendFormat": "Avg",
"range": true,
"refId": "D",
"useBackend": false
Expand Down
1 change: 1 addition & 0 deletions python/sglang/srt/mem_cache/hiradix_cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ def write_backup(self, node: TreeNode, write_back=False):
)
if host_indices is not None:
node.host_value = host_indices
assert len(node.host_value) > 0
self.ongoing_write_through[node.id] = node
if not write_back:
# no need to lock nodes if write back
Expand Down
Loading