Skip to content

Remove inf value for chunked prefill size #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hnyls2002 merged 1 commit into from
Jul 30, 2024
Merged

Remove inf value for chunked prefill size #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions python/sglang/srt/managers/controller/tp_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,11 @@ def get_new_prefill_batch(self) -> Optional[Batch]:
else:
# Add this request to the running batch
if (
new_batch_input_tokens + req.extend_input_len
<= self.chunked_prefill_size
self.chunked_prefill_size is None
or (
new_batch_input_tokens + req.extend_input_len
<= self.chunked_prefill_size
)
or (
req.return_logprob and req.normalized_prompt_logprob is None
)
Expand Down
4 changes: 1 addition & 3 deletions python/sglang/srt/server_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,6 @@ class ServerArgs:
node_rank: Optional[int] = None

def __post_init__(self):
if self.chunked_prefill_size is None:
self.chunked_prefill_size = 1 << 30
if self.tokenizer_path is None:
self.tokenizer_path = self.model_path
if self.mem_fraction_static is None:
Expand Down Expand Up @@ -414,7 +412,7 @@ def check_server_args(self):
), "multi-node data parallel is not supported"

assert not (
self.chunked_prefill_size < (1 << 30) and self.disable_radix_cache
self.chunked_prefill_size is not None and self.disable_radix_cache
), "chunked prefill is not supported with radix cache disabled currently"


Expand Down