Skip to content

fix: resolve arm build issue #8052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

fix: resolve arm build issue #8052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sgl-kernel/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ docker run --rm \
cmake --version

yum install numactl-devel -y && \
yum install libibverbs -y && \
yum install libibverbs -y --nogpgcheck && \
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using --nogpgcheck disables GPG signature verification for this package installation. This poses a significant security risk as it allows the installation of packages without verifying their authenticity, potentially exposing the build process to man-in-the-middle attacks with malicious packages.

Instead of disabling the check, it would be better to investigate the root cause of the GPG check failure. It might be due to a missing or outdated GPG key in the pytorch/manylinuxaarch64-builder image used for ARM builds.

A more secure solution would be to import the correct GPG key for the repository before running yum install. For example:

# This is an example; the key and its location might be different.
rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-CentOS-7
yum install libibverbs -y

Could you please investigate the underlying issue with the GPG key and address that instead of bypassing the security check?

ln -sv /usr/lib64/libibverbs.so.1 /usr/lib64/libibverbs.so && \
${PYTHON_ROOT_PATH}/bin/${TORCH_INSTALL} && \
${PYTHON_ROOT_PATH}/bin/pip install --no-cache-dir ninja setuptools==75.0.0 wheel==0.41.0 numpy uv scikit-build-core && \
Expand Down
Loading