Fix is_sm90_supported

[Edenzzzz]

Motivation

Fixes a typo in #7278. The min cuda version supporting sm90 is 11.8 (see https://forums.developer.nvidia.com/t/minimum-required-cuda-version-by-gpu/276955/2)
cc @yinfan98 @Alcanderian

Modifications

Checklist

• Format your code according to the Code Formatting with Pre-Commit.
• Add unit tests as outlined in the Running Unit Tests.
• Update documentation / docstrings / example tutorials as needed, according to Writing Documentation.
• Provide throughput / latency benchmark results and accuracy evaluation results as needed, according to Benchmark and Profiling and Accuracy Results.
• For reviewers: If you haven't made any contributions to this PR and are only assisting with merging the main branch, please remove yourself as a co-author when merging the PR.
• Please feel free to join our Slack channel at https://slack.sglang.ai to discuss your PR.

[gemini-code-assist]

Summary of Changes

Hello @Edenzzzz, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the CUDA version check for SM90 (Hopper) GPU architecture support, ensuring that the system correctly identifies compatible CUDA environments. The change fixes a typo that previously specified an incorrect minimum CUDA version.

Highlights

• CUDA Version Correction: Corrected the minimum required CUDA version for SM90 (Hopper architecture) support from 12.8 to 11.8 within the is_sm90_supported utility function.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes the minimum required CUDA version for sm90 support. A suggestion has been added to improve the robustness of the version comparison.

[gemini-code-assist]

Comparing version strings directly using >= is not reliable. For example, '11.10' would be evaluated as less than '11.8'.

Consider parsing the version string into a tuple of integers for accurate comparison.

Suggested change

	torch.version.cuda >= "11.8"
	tuple(map(int, torch.version.cuda.split('.'))) >= (11, 8)

[Edenzzzz]

I believe this shouldn't be an issue, as cuda versions have only one decimal digit
https://developer.nvidia.com/cuda-toolkit-archive