Skip to content

Fix sgl-router startup crash #7619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2025
Merged

Fix sgl-router startup crash #7619

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8538c6
Fix sgl-router startup crash
finetunej Jun 28, 2025
5c08a6b
Remove pointless comment
finetunej Jun 28, 2025
dc4245a
Log router health-check thread panics
finetunej Jun 28, 2025
69fc051
Merge branch 'main' into finetunej-patch-1
slin1237 Jun 28, 2025
3479529
Merge branch 'main' into finetunej-patch-1
slin1237 Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion sgl-router/src/router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,15 @@ impl Router {
}
_ => {
// Wait until all workers are healthy for regular modes
Self::wait_for_healthy_workers(&worker_urls, timeout_secs, interval_secs)?;
let worker_urls = worker_urls.clone();
std::thread::spawn(move || {
Self::wait_for_healthy_workers(&worker_urls, timeout_secs, interval_secs)
})
.join()
.map_err(|e| {
error!("Health-check thread panicked: {:?}", e);
format!("Health-check thread panicked: {e:?}")
})??;
}
}

Expand Down
Loading