Skip to content

fix: Fix CI test_function_call_parser.py #7425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
+1 −1
Merged

fix: Fix CI test_function_call_parser.py #7425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/sglang/srt/function_call/base_format_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def parse_streaming_increment(
self.has_tool_call(current_text)
or (
self.current_tool_id > 0
and current_text.startswith(self.tool_call_separator + "{")
and current_text.startswith(self.tool_call_separator)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding a check to ensure self.tool_call_separator is not empty before the startswith call to avoid perpetually parsing subsequent text as a tool call if a subclass were to set self.tool_call_separator to an empty string.

Suggested change
and current_text.startswith(self.tool_call_separator)
and self.tool_call_separator and current_text.startswith(self.tool_call_separator)

)
):
# Only clear buffer if we're sure no tool call is starting
Expand Down
Loading