Skip to content

Conversation

@hnyls2002
Copy link
Collaborator

Reverts #7394

This broke the CI

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, despite its title indicating a revert, appears to re-introduce or apply a previous change related to handling Qwen25 invoke function call streaming responses. The stated intent in the title and description is to revert a change that broke CI, but the provided patch content shows the application of the original modification to the base_format_detector.py file.

Highlights

  • Discrepancy with Title/Intent: While the pull request title and description indicate a revert of sgl-project/sglang#7394 due to CI breakage, the provided patch content shows the application of the changes from that original PR, rather than its undoing.
  • Modification to Tool Call Detection Logic: In python/sglang/srt/function_call/base_format_detector.py, the logic within the parse_streaming_increment function for detecting tool calls in streaming responses has been updated.
  • Updated Conditions for Streaming Responses: The condition self.has_tool_call(current_text) has been replaced by two new conditions: self.bot_token in current_text and current_text.startswith("{"). These new conditions are now part of the if not (...) statement that determines the start of a new tool call sequence.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous bug fix that introduced issues in the CI. The change removes the condition current_text.startswith("{") from the parse_streaming_increment function in base_format_detector.py.

@hnyls2002 hnyls2002 self-assigned this Jun 21, 2025
@hnyls2002
Copy link
Collaborator Author

This is fixed by #7425

@hnyls2002 hnyls2002 closed this Jun 21, 2025
@zhyncs zhyncs deleted the revert-7394-fix_qwen25_function_call branch June 21, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants