Skip to content

bugfix: Prevent global mutation of conv.stop_str across requests #7347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025
Merged

bugfix: Prevent global mutation of conv.stop_str across requests #7347

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c9f240
fix stop_str bugfix
huangtingwei9988 Jun 19, 2025
2db2945
Resolve merge conflicts
CatherineSue Jun 24, 2025
4612146
Merge branch 'main' into fix_stop_fix
CatherineSue Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/sglang/srt/entrypoints/openai/serving_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import copy
import json
import logging
import time
Expand Down Expand Up @@ -292,7 +293,7 @@ def _apply_conversation_template(
image_data = conv.image_data if conv.image_data else None
audio_data = conv.audio_data if conv.audio_data else None
modalities = conv.modalities if conv.modalities else []
stop = conv.stop_str or [] if not request.ignore_eos else []
stop = copy.copy(conv.stop_str or [] if not request.ignore_eos else [])

if request.stop:
if isinstance(request.stop, str):
Expand Down
Loading