Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/pr-test-sgl-kernel.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ jobs:
strategy:
matrix:
include:
- python-version: '3.9'
cuda-version: '11.8'
- python-version: '3.9'
cuda-version: '12.4'
- python-version: '3.9'
Expand Down Expand Up @@ -88,7 +86,7 @@ jobs:
- name: Install
run: |
bash scripts/ci_install_dependency.sh
pip3 install torch==2.6.0 torchvision && pip3 install pytest
pip3 install torch==2.7.1 torchvision && pip3 install pytest
pip3 uninstall sgl-kernel -y || true
pip3 install sgl-kernel/dist/*whl --force-reinstall --no-deps
pip3 list | grep sgl-kernel
Expand Down Expand Up @@ -120,6 +118,7 @@ jobs:
- name: Install
run: |
bash scripts/ci_install_dependency.sh
pip3 install torch==2.7.1 torchvision
pip3 uninstall sgl-kernel -y || true
pip3 install sgl-kernel/dist/*whl --force-reinstall --no-deps
pip3 list | grep sgl-kernel
Expand Down
2 changes: 1 addition & 1 deletion docker/Dockerfile.blackwell
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ RUN echo 'tzdata tzdata/Areas select America' | debconf-set-selections \

RUN pip3 install torch==2.7.0 torchvision==0.22.0 torchaudio==2.7.0 --index-url https://download.pytorch.org/whl/cu128 --break-system-packages

RUN pip3 install https://github.com/sgl-project/whl/releases/download/v0.1.6.post1/sgl_kernel-0.1.6.post1+cu128-cp39-abi3-manylinux2014_x86_64.whl --break-system-packages \
RUN pip3 install https://github.com/sgl-project/whl/releases/download/v0.1.7/sgl_kernel-0.1.7+cu128-cp39-abi3-manylinux2014_x86_64.whl --break-system-packages \
&& pip3 install setuptools==75.0.0 wheel scikit-build-core --break-system-packages
Comment on lines +23 to 24
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change updates sgl_kernel to v0.1.7.

It's important to ensure this new kernel version is compatible with torch==2.7.0, which is installed on line 21 of this Dockerfile (note: line 21 is not part of the current diff). Most other configuration files in this PR (e.g., sgl-kernel/build.sh, sgl-kernel/pyproject.toml) are updating their Torch dependencies to 2.7.1.

Could you please verify if sgl_kernel-0.1.7 is intended to be used with torch==2.7.0, or if line 21 of this Dockerfile should also be updated to torch==2.7.1? A mismatch could lead to unexpected behavior or runtime errors if sgl_kernel-0.1.7 was built against or expects torch==2.7.1.


RUN git clone --depth=1 https://github.com/sgl-project/sglang.git \
Expand Down
10 changes: 3 additions & 7 deletions sgl-kernel/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,15 @@ if [ ${ARCH} = "aarch64" ]; then
BUILDER_NAME="pytorch/manylinuxaarch64-builder"
else
LIBCUDA_ARCH=${ARCH}
if [ ${CUDA_VERSION} = "12.8" ]; then
BUILDER_NAME="pytorch/manylinux2_28-builder"
else
BUILDER_NAME="pytorch/manylinux-builder"
fi
BUILDER_NAME="pytorch/manylinux2_28-builder"
fi

if [ ${CUDA_VERSION} = "12.8" ]; then
DOCKER_IMAGE="${BUILDER_NAME}:cuda${CUDA_VERSION}"
TORCH_INSTALL="pip install --no-cache-dir torch==2.7.0 --index-url https://download.pytorch.org/whl/cu${CUDA_VERSION//.}"
TORCH_INSTALL="pip install --no-cache-dir torch==2.7.1 --index-url https://download.pytorch.org/whl/cu${CUDA_VERSION//.}"
else
DOCKER_IMAGE="${BUILDER_NAME}:cuda${CUDA_VERSION}"
TORCH_INSTALL="pip install --no-cache-dir torch==2.6.0 --index-url https://download.pytorch.org/whl/cu${CUDA_VERSION//.}"
TORCH_INSTALL="pip install --no-cache-dir torch==2.7.1"
fi

docker run --rm \
Expand Down
4 changes: 2 additions & 2 deletions sgl-kernel/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[build-system]
requires = [
"scikit-build-core>=0.10",
"torch>=2.6.0",
"torch>=2.7.1",
"wheel",
]
build-backend = "scikit_build_core.build"

[project]
name = "sgl-kernel"
version = "0.1.6.post1"
version = "0.1.7"
description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.9"
Expand Down
4 changes: 2 additions & 2 deletions sgl-kernel/pyproject_cpu.toml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[build-system]
requires = [
"scikit-build-core>=0.10",
"torch>=2.6.0",
"torch>=2.7.1",
"wheel",
]
build-backend = "scikit_build_core.build"

[project]
name = "sgl-kernel"
version = "0.1.6.post1"
version = "0.1.7"
description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.9"
Expand Down
4 changes: 2 additions & 2 deletions sgl-kernel/pyproject_rocm.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
requires = [
"setuptools>=75.0",
"scikit-build-core>=0.10",
"torch>=2.6.0",
"torch>=2.7.1",
"wheel",
]
build-backend = "setuptools.build_meta"

[project]
name = "sgl-kernel"
version = "0.1.6.post1"
version = "0.1.7"
description = "Kernel Library for SGLang"
readme = "README.md"
requires-python = ">=3.9"
Expand Down
2 changes: 1 addition & 1 deletion sgl-kernel/python/sgl_kernel/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.1.6.post1"
__version__ = "0.1.7"
Loading