Skip to content

Fix LoRA bench #6719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Fix LoRA bench #6719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d7debd
fix
Edenzzzz May 28, 2025
0923e95
Merge branch 'main' into fix_lora
Edenzzzz May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions benchmark/lora/lora_bench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,13 @@ async def benchmark(
raise ValueError(f"Unknown backend: {backend}")

print("Starting initial single prompt test run...")
test_prompt, test_prompt_len, test_output_len = input_requests[0]
test_request = input_requests[0]
test_input = RequestFuncInput(
model=model_id,
prompt=test_prompt,
prompt=test_request.prompt,
api_url=api_url,
prompt_len=test_prompt_len,
output_len=test_output_len,
prompt_len=test_request.prompt_len,
output_len=test_request.output_len,
lora_name="dummy", # the lora_name argument will not be used
image_data=None,
extra_request_body=extra_request_body,
Expand All @@ -187,13 +187,12 @@ async def benchmark(
benchmark_start_time = time.perf_counter()
tasks: List[asyncio.Task] = []
async for request in get_request(input_requests, request_rate):
prompt, prompt_len, output_len = request
request_func_input = RequestFuncInput(
model=model_id,
prompt=prompt,
prompt=request.prompt,
api_url=api_url,
prompt_len=prompt_len,
output_len=output_len,
prompt_len=request.prompt_len,
output_len=request.output_len,
lora_name="dummy",
image_data=None,
extra_request_body=extra_request_body,
Expand Down
Loading