feat: support internlm2#636
Merged
Ying1123 merged 1 commit intosgl-project:mainfrom Jul 17, 2024
zhyncs:internlm2
Merged
Conversation
Ying1123
approved these changes
Jul 17, 2024
Contributor
There was a problem hiding this comment.
On my machine (H100):
SRT:
prefill logits (final) tensor([[262., 262., 342., ..., 272., 290., 240.],
[272., 276., 348., ..., 284., 302., 247.],
[360., 362., 450., ..., 378., 392., 326.]], device='cuda:0',
dtype=torch.bfloat16)
HF:
prefill logits tensor([265.5000, 264.5000, 345.0000, ..., 274.7500, 293.0000, 242.7500],
device='cuda:0')
prefill logits tensor([279.2500, 281.7500, 355.2500, ..., 290.0000, 310.0000, 252.6250],
device='cuda:0')
prefill logits tensor([359.7500, 361.2500, 448.5000, ..., 377.0000, 390.5000, 324.5000],
device='cuda:0')
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
cen121212
pushed a commit
to cen121212/sglang
that referenced
this pull request
Nov 10, 2025
….py (sgl-project#636) * Create test_ascend_disaggregation_deepep_k8s_2p1d.py * Create pr-test-npu-innersource.yml * Add files via upload * Add files via upload * Delete test_ascend_tp1_bf16.py * Delete test/srt/ascend_k8s/test_vlm_models_glm_4_1v_9b_thinking.py * Create deepep.yaml * Create run_ascend_ci.py * Create run_ascend_deepep.sh * Update run_suite.py * Update pr-test-npu-innersource.yml * Update pr-test-npu-innersource.yml * Update pr-test-npu-innersource.yml * Update run_ascend_deepep.sh * 111 * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update pr-test-npu-innersource.yml * Update pr-test-npu-innersource.yml * Update pr-test-npu-innersource.yml * Update pr-test-npu-innersource.yml * Update pr-test-npu-innersource.yml * Update pr-test-npu-innersource.yml * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py * Update run_ascend_ci.py * Update test_ascend_disaggregation_deepep_k8s_2p1d.py --------- Co-authored-by: Sugar920 <duzhangchen@h-partners.com>
michaelzhang-ai
added a commit
to michaelzhang-ai/sglang
that referenced
this pull request
Mar 20, 2026
…ccuracy threshold PR sgl-project#17784 (transformers 5.3.0 upgrade) changed grok.py to access config.rope_parameters["rope_theta"] directly, but GitConfig (grok-2) does not have this attribute, crashing the server on startup with AttributeError: 'GitConfig' object has no attribute 'rope_parameters'. Restore safe access via getattr with fallback, matching the pattern used elsewhere in the codebase. Also lower the MI325 Grok-2 GSM8K accuracy threshold from 0.915 to 0.90 to match the MI35x test, since nightly sgl-project#636 showed 0.910 which is within normal run-to-run variance.
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Ying1123 @merrymercy @hnyls2002
tested with
internlm2-chat-7btransformers
sglang