Skip to content

Add --enable-p2p-check option - #599

Merged
hnyls2002 merged 3 commits into
mainfrom
p2p-check
Jul 7, 2024
Merged

hnyls2002 merged 3 commits into
mainfrom
p2p-check

Conversation

@hnyls2002

Copy link
Copy Markdown
Collaborator

Not only 4090, there are a lot of old GPUs that cannot support p2p access and we cannot always skip the p2p checking process.

The RTX 40 hack can also be discarded as we can use --enable-p2p-check now.

@hnyls2002

Copy link
Copy Markdown
Collaborator Author

This PR is related to #531 and may probably fix #552.

@Qubitium @ZX-ModelCloud I don't know whether just checking for 4090 would cause errors or not. Is there anyone who can help me test with 4090 using --enable-p2p-checking?

@ZX-ModelCloud

Copy link
Copy Markdown
Contributor

This PR is related to #531 and may probably fix #552.

@Qubitium @ZX-ModelCloud I don't know whether just checking for 4090 would cause errors or not. Is there anyone who can help me test with 4090 using --enable-p2p-checking?

When loading the model with two GPUs 4090 and --tp-size =2. Add --enable-p2p-check parameter, load model works fine and inference works fine. Without adding it, it doesn't work.

@hnyls2002

Copy link
Copy Markdown
Collaborator Author

@ZX-ModelCloud Ok, so I think making this as an option is better than the hack of skip checking only for RTX 40 series.

When people get errors, they should add this option manually.

@hnyls2002
hnyls2002 merged commit 5304b4e into main Jul 7, 2024
@hnyls2002
hnyls2002 deleted the p2p-check branch July 7, 2024 06:34
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
@wavelet2008

Copy link
Copy Markdown

too slow add --enable-p2p-check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants