Skip to content

Fix torch memory saver not enabled in DP scenario #5560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2025
Merged

Fix torch memory saver not enabled in DP scenario #5560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d987de1
more
fzyzcjy Apr 20, 2025
df8957f
Merge branch 'main' into feat/mem_saver_dp
zhyncs Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/sglang/srt/managers/data_parallel_controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
)
from sglang.srt.managers.scheduler import run_scheduler_process
from sglang.srt.server_args import PortArgs, ServerArgs
from sglang.srt.torch_memory_saver_adapter import TorchMemorySaverAdapter
from sglang.srt.utils import bind_port, configure_logger, get_zmq_socket
from sglang.utils import get_exception_traceback

Expand Down Expand Up @@ -174,6 +175,10 @@ def launch_tensor_parallel_group(
if not server_args.enable_dp_attention:
logger.info(f"Launch DP{dp_rank} starting at GPU #{base_gpu_id}.")

memory_saver_adapter = TorchMemorySaverAdapter.create(
enable=server_args.enable_memory_saver
)

# Launch tensor parallel scheduler processes
scheduler_pipe_readers = []
tp_size_per_node = server_args.tp_size // server_args.nnodes
Expand Down Expand Up @@ -208,7 +213,8 @@ def launch_tensor_parallel_group(
target=run_scheduler_process,
args=(server_args, rank_port_args, gpu_id, tp_rank, dp_rank, writer),
)
proc.start()
with memory_saver_adapter.configure_subprocess():
proc.start()
self.scheduler_procs.append(proc)
scheduler_pipe_readers.append(reader)

Expand Down
Loading