Skip to content

Make the server random by default #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 2 commits into from
May 29, 2024
Merged

Make the server random by default #488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6121553
do not set the default value of global random seed so the server can …
merrymercy May 29, 2024
f7413f3
update
merrymercy May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/sglang/srt/managers/controller/tp_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,8 @@ def __init__(
self.int_token_logit_bias = torch.tensor(
get_int_token_logit_bias(self.tokenizer, self.model_config.vocab_size)
)
set_random_seed(server_args.random_seed)
if server_args.random_seed is not None:
set_random_seed(server_args.random_seed)

# Print info
logger.info(
Expand Down
4 changes: 2 additions & 2 deletions python/sglang/srt/server_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class ServerArgs:
# Other runtime options
tp_size: int = 1
stream_interval: int = 8
random_seed: int = 42
random_seed: Optional[int] = None

# Logging
log_level: str = "info"
Expand Down Expand Up @@ -194,7 +194,7 @@ def add_cli_args(parser: argparse.ArgumentParser):
"--random-seed",
type=int,
default=ServerArgs.random_seed,
help="Random seed.",
help="The global random seed of the server.",
)
parser.add_argument(
"--log-level",
Expand Down